CRITICAL FIX FOR WINDOWS:
Problem: Git on Windows uses CRLF, but deployed files use LF. When comparing
with slurp (byte-for-byte base64 comparison), CRLF != LF causes false positives.
Solution: Decode base64 content and normalize line endings:
- Replace CRLF with LF in both Git and server file content
- Then compare the normalized content
This ensures that line ending differences don't trigger false OUT_OF_SYNC alerts.
After deploy, content will match regardless of platform line ending differences.
CRITICAL FIX:
Problem: Previous version used multiple stat operations and loops which created
too many file descriptors and fsnotify watchers, causing 'too many open files' errors.
Solution: Use only:
- slurp: Direct file content reading (no watchers)
- find: Single operation to list directory files (no loops)
New logic is clean and simple:
1. Read Git rsyslog.conf + server rsyslog.conf (slurp)
2. Compare content directly (byte comparison)
3. List Git rsyslog.d files + server rsyslog.d files (find)
4. Compare file names (no permission checks, no loops)
5. Output DRIFTED_FILES and SYNC_STATUS markers
This eliminates file descriptor exhaustion while maintaining correct drift detection.
After deploy, when content matches, playbook exits 0 (SYNCED).
CRITICAL FIX:
Problem: drift-check.yml was using 'copy' module in check_mode, which compares:
- File content ✓
- Permissions (owner, group, mode) ✗
- Ownership ✗
After deploy, files have root:root 0644 permissions. Even though content matches,
the copy module marked files as 'changed' because permissions were being compared.
This caused false OUT_OF_SYNC reports even when configuration was actually synced.
Solution: Use MD5 checksum-based comparison instead:
- Compare only file CONTENT using stat checksums
- Ignore permissions/ownership differences
- This is what matters for config management
Also fixed URLs:
- Changed back from port 80 to port 5000 (API only)
- Updated service name to gitops-status-api
Now drift detection only triggers on actual config changes, not permission differences.
After successful deploy, should correctly report SYNCED status.
CRITICAL FIXES:
1. Fix API URL port: 5000 → 80 (.woodpecker.yml)
- update-gitops-status step was POSTing to wrong port
- gitops-status-server Service exposes port 80, not 5000
- This caused silent POST failures that weren't detected
2. Initialize missing_on_server variable (drift-check.yml)
- Variable was only set inside block scope
- Could remain undefined if block failed or didn't execute
- Now initialized to empty list before block runs
- Prevents undefined variable errors in container environment
3. Fix drift detection logic (drift-check.yml)
- Changed from: drift_detected uses extra_files_on_server flag
- Changed to: drift_detected directly checks missing_on_server length
- Adds safety with | default([]) filter
- Prevents false positives when extra_files_on_server wasn't set properly
ROOT CAUSE:
The combination of port 5000, uninitialized variables, and flag-based logic
caused the playbook to report OUT_OF_SYNC without listing changed files
(drift_count=0, files=[]). After deployment, server config matches Git,
so drift_detected should be false and playbook should exit 0 with SYNCED status.
Now correctly reports SYNCED after successful deploy.
- Add debug output showing rsyslogd_check.diff structure
- Simplify file extraction logic for rsyslog.d directory changes
- Show full JSON payload before sending to API
- Add connectivity test to gitops-status-server before POST
- Show curl command and response codes for debugging
- Display warning if OUT_OF_SYNC but no files extracted
This helps diagnose why drift is detected but files aren't listed in the JSON.
