CRITICAL FIXES:
1. Fix API URL port: 5000 → 80 (.woodpecker.yml)
- update-gitops-status step was POSTing to wrong port
- gitops-status-server Service exposes port 80, not 5000
- This caused silent POST failures that weren't detected
2. Initialize missing_on_server variable (drift-check.yml)
- Variable was only set inside block scope
- Could remain undefined if block failed or didn't execute
- Now initialized to empty list before block runs
- Prevents undefined variable errors in container environment
3. Fix drift detection logic (drift-check.yml)
- Changed from: drift_detected uses extra_files_on_server flag
- Changed to: drift_detected directly checks missing_on_server length
- Adds safety with | default([]) filter
- Prevents false positives when extra_files_on_server wasn't set properly
ROOT CAUSE:
The combination of port 5000, uninitialized variables, and flag-based logic
caused the playbook to report OUT_OF_SYNC without listing changed files
(drift_count=0, files=[]). After deployment, server config matches Git,
so drift_detected should be false and playbook should exit 0 with SYNCED status.
Now correctly reports SYNCED after successful deploy.
- Add debug output showing rsyslogd_check.diff structure
- Simplify file extraction logic for rsyslog.d directory changes
- Show full JSON payload before sending to API
- Add connectivity test to gitops-status-server before POST
- Show curl command and response codes for debugging
- Display warning if OUT_OF_SYNC but no files extracted
This helps diagnose why drift is detected but files aren't listed in the JSON.
