From ecd5c0c6d72fd736aca8ba7c869809d9ec1fb0e6 Mon Sep 17 00:00:00 2001
From: dvirlabs <dvirlabs@gmail.com>
Date: Wed, 25 Mar 2026 17:26:58 +0200
Subject: [PATCH] Fix ttyd stuck

---
 charts/ttyd/templates/deployment.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/charts/ttyd/templates/deployment.yaml b/charts/ttyd/templates/deployment.yaml
index 2bf6a53..d74f970 100644
--- a/charts/ttyd/templates/deployment.yaml
+++ b/charts/ttyd/templates/deployment.yaml
@@ -33,11 +33,19 @@ spec:
           imagePullPolicy: {{ .Values.image.pullPolicy }}
           # The tsl0922/ttyd image uses tini as entrypoint (tini -- <cmd>).
           # args replaces CMD, so ttyd must be the first element.
+          # "--" is required to separate ttyd flags from the shell command;
+          # without it, ttyd does not correctly attach the shell as an
+          # interactive process, causing the browser terminal to accept no input.
           # To use kubectl, switch image.repository to a custom image that bundles ttyd + kubectl.
           args:
             - "ttyd"
             - "--port={{ .Values.ttyd.port }}"
+            - "--"
             - {{ .Values.ttyd.command | quote }}
+          # tty + stdin are required for the browser terminal to accept keyboard input.
+          # Without these the PTY is not allocated and the shell is non-interactive.
+          tty: true
+          stdin: true
           ports:
             - name: http
               containerPort: {{ .Values.ttyd.port }}